Replacing subWorkflow to childWorkflow to align with other SDKs #1168
+354
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: salaboy <[email protected]>
cicoyle
approved these changes
Dec 4, 2024
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
Rename lgtm, I believe we will need to make note of this being a breaking change since it'll break users with ctx.callSubWorkflow since its now: ctx.callChildWorkflow. Otherwise, we should mark it as a deprecated alias and leave it for 2 releases then remove it. cc/ @artursouza for thoughts?
Collaborator
Author
|
@cicoyle I thought about that, but instead of doing that I would just add it in the release notes, for when people do upgrade they just replace the method name. Doing a full deprecation cycle for aligning with other SDKs seems an overkill |
Contributor
|
workflows is alpha, so we can break it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
using ChildWorkflows instead of SubWorkflows to align with other SDKs and docs
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1155
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: